vesoft-inc / nebula-go

Nebula client in Golang
Apache License 2.0
134 stars 70 forks source link

Support scan Nebula subgraph results (vertex and edge) #346

Open haoxins opened 2 months ago

haoxins commented 2 months ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

haoxins commented 2 months ago

need to add some tests

haoxins commented 2 months ago

ok, at least I didn't break anything :joy:

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.10680% with 38 lines in your changes missing coverage. Please review.

Project coverage is 64.41%. Comparing base (4e4de32) to head (b6d665c).

Files with missing lines Patch % Lines
result_set.go 63.10% 30 Missing and 8 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #346 +/- ## ========================================== + Coverage 64.36% 64.41% +0.05% ========================================== Files 11 11 Lines 2963 3041 +78 ========================================== + Hits 1907 1959 +52 - Misses 897 915 +18 - Partials 159 167 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wey-gu commented 2 months ago

@haoxins is this still in draft state or?

haoxins commented 2 months ago

@haoxins is this still in draft state or?

draft, I need to add some basic tests later

haoxins commented 2 months ago

ready to go~

wey-gu commented 1 month ago

@Nicole00 kindly take a review on this work, please? 😊

haoxins commented 6 days ago

hello, any advice?