vesoft-inc / nebula-importer

Nebula Graph Importer with Go
Apache License 2.0
90 stars 60 forks source link

feat: support gcs #278

Closed OldPanda closed 1 year ago

OldPanda commented 1 year ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

https://github.com/vesoft-inc/nebula-importer/issues/279

Description:

To allow users to import csv files from GCS.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

wey-gu commented 1 year ago

Wow, thanks @OldPanda for the great contribution :) Long time no see~~

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.14 :warning:

Comparison is base (dd462b5) 90.89% compared to head (685d0ce) 90.76%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #278 +/- ## ========================================== - Coverage 90.89% 90.76% -0.14% ========================================== Files 77 78 +1 Lines 3648 3693 +45 ========================================== + Hits 3316 3352 +36 - Misses 326 332 +6 - Partials 6 9 +3 ``` | [Impacted Files](https://app.codecov.io/gh/vesoft-inc/nebula-importer/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc) | Coverage Δ | | |---|---|---| | [pkg/source/config.go](https://app.codecov.io/gh/vesoft-inc/nebula-importer/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-cGtnL3NvdXJjZS9jb25maWcuZ28=) | `88.00% <0.00%> (-12.00%)` | :arrow_down: | | [pkg/source/gcs.go](https://app.codecov.io/gh/vesoft-inc/nebula-importer/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-cGtnL3NvdXJjZS9nY3MuZ28=) | `85.00% <85.00%> (ø)` | | | [pkg/source/source.go](https://app.codecov.io/gh/vesoft-inc/nebula-importer/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-cGtnL3NvdXJjZS9zb3VyY2UuZ28=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

OldPanda commented 1 year ago

Long time no see @wey-gu ! I'm glad to have a chance to contribute to NebulaGraph again!