Closed haoxins closed 1 year ago
@haoxins Thanks! Can you fix the testing ? BTW, do you know which env has the effect?
I need to find a solution to fix the test. The test failed because it is not running on the GKE/GCE environment.
https://cloud.google.com/docs/authentication/application-default-credentials?hl=zh-cn#attached-sa
@haoxins Setting WithoutAuthentication
to true
may solve the problem.
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
1cbec84
) 87.89% compared to head (feb24d8
) 87.89%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@haoxins Setting
WithoutAuthentication
totrue
may solve the problem.
fixed
@haoxins Thanks a lot!
What type of PR is this?
What problem(s) does this PR solve?
When you run the application in the GCP ENVs, such as GKE or GCE. The GCS client will try to get credentials underlying the ENVs.
See https://cloud.google.com/kubernetes-engine/docs/concepts/workload-identity
Unless the user specifies that, we shouldn't set the
WithoutAuthentication
option.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: