vesoft-inc / nebula-java

Client API and data importer of Nebula Graph in Java
Apache License 2.0
164 stars 121 forks source link

add executeJsonWithParameter, executeJson to SessionPool #580

Closed cjdxhjj closed 5 months ago

cjdxhjj commented 6 months ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

add executeJsonWithParameter, executeJson to SessionPool

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Nicole00 commented 5 months ago

there's two checkstyle violations, could you please format the code?

cjdxhjj commented 5 months ago

@Nicole00 ok

codecov-commenter commented 5 months ago

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (312a4f2) 63.33% compared to head (4965191) 62.83%.

Files Patch % Lines
...va/com/vesoft/nebula/client/graph/SessionPool.java 0.00% 27 Missing :warning:
.../com/vesoft/nebula/client/graph/NebulaSession.java 0.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #580 +/- ## ============================================ - Coverage 63.33% 62.83% -0.50% + Complexity 812 811 -1 ============================================ Files 72 72 Lines 4006 4036 +30 Branches 542 547 +5 ============================================ - Hits 2537 2536 -1 - Misses 1098 1128 +30 - Partials 371 372 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cjdxhjj commented 5 months ago

@Nicole00 thanks

QingZ11 commented 4 months ago

@Nicole00 thanks

Thank you for your great contribution, cjdxhjj.