vesoft-inc / nebula-operator

Operation utilities for Nebula Graph
https://vesoft-inc.github.io/nebula-operator
Apache License 2.0
81 stars 30 forks source link

NA minReplica maxReplica validation #500

Closed MegaByte875 closed 5 months ago

MegaByte875 commented 7 months ago

Please check the FAQ documentation before raising an issue

Describe the bug (required)

If minReplica > maxReplica , apply does not raise error, a few instances of graphd will cycle between being created and terminating state. Proposing adding a validation logic.

Your Environments (required)

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context

kevinliu24 commented 5 months ago

Design page: https://nebula-graph.atlassian.net/wiki/spaces/TDEV/pages/149094404/Admissions+Webhook+for+Autoscaler+and+Passing+Cert+via+Sidecar

MegaByte875 commented 5 months ago

https://github.com/vesoft-inc/nebula-operator/pull/502