search

vesoft-inc / nebula-operator

Operation utilities for Nebula Graph
https://vesoft-inc.github.io/nebula-operator
Apache License 2.0
81 stars 30 forks source link

Nebula Console Pod not use user defined ImagePullPolicy which configured in values.xml #526

Open qian2009 opened 2 months ago

qian2009 commented 2 months ago

I need to deploy nebula at a offline environment, but it's not easy because of the ImagePullPolicy is 'Always', no matter how I configure in the value.xml file.

Finally, I check the source code and found that the ImagePullPolicy of Nebula Console Pod was just hard coded:


    container := corev1.Container{
        Name:            "console",
        Image:           getConsoleImage(nc.Spec.Console),
        ImagePullPolicy: corev1.PullAlways,

I think the ImagePullPolicy should be specified in values.xml rather than hard coded
MegaByte875 commented 2 months ago

Thanks, I will fix it assp.