search

vesoft-inc / nebula-python

Client API of Nebula Graph in Python
193 stars 78 forks source link

add test version check #151

Closed HarrisChu closed 3 years ago

HarrisChu commented 3 years ago
  1. fix exception
  2. add a test case for version check
Aiee commented 3 years ago

Version check is more like a functionality on the server-side and we already had tests there. Is it necessary to test it on the client-side?

HarrisChu commented 3 years ago

need to add the case to verify the client behavior if client version is not in white list. but cannot modify version in client config.

maybe we could define function like below, and then add negative cases.

    def open(self, ip, port, timeout, version=None):