Closed alan890104 closed 2 years ago
Wow, the cast is sweet and awesome @alan890104 thanks!
Could you please check its linting with make fmt-check
?
No problem. Done.
@alan890104 could you please check its tests, where a docker/docker-compose env is required here.
docker-compose -f docker-compose.yaml up -d
sleep 45
pytest -s -v -k "not SSL"
ok i'll check it
@wey-gu I found that python3.6 does not support this statement
from __future__ import annotations
so I change the order of ValueWrapper
and delete import to support python 3.6
@wey-gu I found that python3.6 does not support this statement
from __future__ import annotations
so I change the order of
ValueWrapper
and delete import to support python 3.6
Sorry for staying in a non-modern python version to enable proper typing handling in runtime. Thanks for your time struggling on this.
why change the code order in last commit?
@wey-gu I found that python3.6 does not support this statement
from __future__ import annotations
so I change the order of
ValueWrapper
and delete import to support python 3.6
@HarrisChu In order to add typings for ValueWrapper
, I have to change the code order. Or it will cause class-name-forward-reference
error.
you can use:
def as_node(self) -> "Node":
@HarrisChu I revert my commit and fix the typing as you said. Tks!
LGTM
I've done two things in commits for improving user experience on nebula-python.
DataObject.ValueWrapper
example/FormatResp