Closed wey-gu closed 1 year ago
Base: 27.31% // Head: 77.46% // Increases project coverage by +50.14%
:tada:
Coverage data is based on head (
10f731c
) compared to base (2c64858
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@Aiee not sure if this file is generated or manually composed, this change is needed or it cannot support TLSv1.3(SNI).
@Aiee not sure if this file is generated or manually composed, this change is needed or it cannot support TLSv1.3(SNI).
The files under the fbthrift dir are just a python library. You can find the upstream here https://github.com/facebook/fbthrift/tree/main/thrift/lib/py
From https://github.com/facebook/fbthrift/blob/main/thrift/lib/py/transport/TSSLSocket.py it seems fbthrift hasn't supported TLSv1.3 yet, and I'm not sure if it is a good idea to hack the library like this.
It's too long. I'll close it and reopen if necessary.
SSL_set_tlsext_host_name is the openssl function to add SNI, which is needed in TLSv1.3.
ref: