vesoft-inc / nebula-python

Client API of Nebula Graph in Python
194 stars 76 forks source link

Replace the protocol with header protocol #254

Closed Aiee closed 1 year ago

Aiee commented 1 year ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Address https://github.com/vesoft-inc/nebula/issues/5191

Description:

Replace the protocol with header protocol

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

using compact protocol still cause nebula3.Exception.IOErrorException: Header transport frame was too large protocol = TCompactProtocol.TCompactProtocol(transport)

codecov-commenter commented 1 year ago

Codecov Report

Base: 77.45% // Head: 77.61% // Increases project coverage by +0.16% :tada:

Coverage data is based on head (4a2a2b9) compared to base (dde7640). Patch coverage: 95.45% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #254 +/- ## ========================================== + Coverage 77.45% 77.61% +0.16% ========================================== Files 18 18 Lines 2408 2408 ========================================== + Hits 1865 1869 +4 + Misses 543 539 -4 ``` | [Impacted Files](https://codecov.io/gh/vesoft-inc/nebula-python/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc) | Coverage Δ | | |---|---|---| | [nebula3/gclient/net/ConnectionPool.py](https://codecov.io/gh/vesoft-inc/nebula-python/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-bmVidWxhMy9nY2xpZW50L25ldC9Db25uZWN0aW9uUG9vbC5weQ==) | `93.04% <94.44%> (+1.06%)` | :arrow_up: | | [nebula3/gclient/net/Connection.py](https://codecov.io/gh/vesoft-inc/nebula-python/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-bmVidWxhMy9nY2xpZW50L25ldC9Db25uZWN0aW9uLnB5) | `80.50% <100.00%> (+1.69%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

wey-gu commented 1 year ago

is this related to https://github.com/vesoft-inc/nebula/issues/5190 or other issues actually?

Aiee commented 1 year ago

is this related to vesoft-inc/nebula#5190 or other issues actually?

My bad, I've updated the issue link https://github.com/vesoft-inc/nebula/issues/5191

wey-gu commented 1 year ago

is this related to vesoft-inc/nebula#5190 or other issues actually?

My bad, I've updated the issue link vesoft-inc/nebula#5191

Thanks! So with header protocol, the client will not hang but exit in such huge-sized frame cases, right?

Aiee commented 1 year ago

is this related to vesoft-inc/nebula#5190 or other issues actually?

My bad, I've updated the issue link vesoft-inc/nebula#5191

Thanks! So with header protocol, the client will not hang but exit in such huge-sized frame cases, right?

Correct, an exception indicating the frame size is too large will be thrown.

Nicole00 commented 1 year ago

storage client also needs consideration.