Closed Aiee closed 1 year ago
Base: 77.45% // Head: 77.61% // Increases project coverage by +0.16%
:tada:
Coverage data is based on head (
4a2a2b9
) compared to base (dde7640
). Patch coverage: 95.45% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
is this related to https://github.com/vesoft-inc/nebula/issues/5190 or other issues actually?
is this related to vesoft-inc/nebula#5190 or other issues actually?
My bad, I've updated the issue link https://github.com/vesoft-inc/nebula/issues/5191
is this related to vesoft-inc/nebula#5190 or other issues actually?
My bad, I've updated the issue link vesoft-inc/nebula#5191
Thanks! So with header protocol, the client will not hang but exit in such huge-sized frame cases, right?
is this related to vesoft-inc/nebula#5190 or other issues actually?
My bad, I've updated the issue link vesoft-inc/nebula#5191
Thanks! So with header protocol, the client will not hang but exit in such huge-sized frame cases, right?
Correct, an exception indicating the frame size is too large will be thrown.
storage client also needs consideration.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Address https://github.com/vesoft-inc/nebula/issues/5191
Description:
Replace the protocol with header protocol
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: