search

vesoft-inc / nebula-python

Client API of Nebula Graph in Python
191 stars 75 forks source link

feat: Add get_prop_names methods for scan results #297

Closed haoxins closed 7 months ago

haoxins commented 8 months ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

codecov-commenter commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (469e25f) 77.88% compared to head (844e7e4) 77.83%.

Files Patch % Lines
nebula3/sclient/BaseResult.py 50.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #297 +/- ## ========================================== - Coverage 77.88% 77.83% -0.05% ========================================== Files 18 18 Lines 2419 2423 +4 ========================================== + Hits 1884 1886 +2 - Misses 535 537 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nicole00 commented 8 months ago

Could you please check the ci for 3.12?

wey-gu commented 8 months ago

@haoxins could you please help run pip-compile requirements/dev.in to regenerate the dev.txt?

haoxins commented 8 months ago

@haoxins could you please help run pip-compile requirements/dev.in to regenerate the dev.txt?

@wey-gu done

haoxins commented 8 months ago

can we drop support for <3.9?

wey-gu commented 8 months ago

can we drop support for <3.9?

I think it's fair(as of 2024 Jan) to drop py3.8.

cc @Nicole00 We need to add this to the release note, but it's to me reasonable for now to support py3.9+