Closed haoxins closed 7 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
469e25f
) 77.88% compared to head (844e7e4
) 77.83%.
Files | Patch % | Lines |
---|---|---|
nebula3/sclient/BaseResult.py | 50.00% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could you please check the ci for 3.12?
@haoxins could you please help run pip-compile requirements/dev.in
to regenerate the dev.txt?
@haoxins could you please help run
pip-compile requirements/dev.in
to regenerate the dev.txt?
@wey-gu done
can we drop support for <3.9
?
can we drop support for
<3.9
?
I think it's fair(as of 2024 Jan) to drop py3.8.
cc @Nicole00 We need to add this to the release note, but it's to me reasonable for now to support py3.9+
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: