codecov-commenter
commented
9 months ago Codecov Report
Attention: Patch coverage is 61.90476% with 24 lines in your changes are missing coverage. Please review.
Project coverage is 77.50%. Comparing base (
251c253) to head (54ba2c7).
| Files | Patch % | Lines |
|---|---|---|
| nebula3/gclient/net/Session.py | 50.00% | 14 Missing :warning: |
| nebula3/gclient/net/SessionPool.py | 43.75% | 9 Missing :warning: |
| nebula3/gclient/net/Connection.py | 83.33% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #306 +/- ## ========================================== - Coverage 77.83% 77.50% -0.34% ========================================== Files 18 18 Lines 2423 2485 +62 ========================================== + Hits 1886 1926 +40 - Misses 537 559 +22 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
close: #276
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #276
Description:
other changes
CI changed: avoid using pdm install, this was due to since py3.12, future's installation requires setuptools but setuptools was removed and thus it requires explicit installation/dependency on setuptools, while, the setuptools version cannot be resolved in py3.6.2+ actually, so we have to use pip install to mitigate this. (cc @frostming , I replaced pdm install with pip install, ping you to see if elegant way exists?)