vesoft-inc / nebula-python

Client API of Nebula Graph in Python
194 stars 76 forks source link

Add a base class for functions execute_* #338

Closed BeautyyuYanli closed 5 months ago

BeautyyuYanli commented 5 months ago

In this PR,

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 5 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 75.63%. Comparing base (6895832) to head (bb218fa). Report is 3 commits behind head on master.

Files Patch % Lines
nebula3/gclient/net/ConnectionPool.py 75.00% 4 Missing :warning:
nebula3/gclient/net/Session.py 77.77% 2 Missing :warning:
nebula3/gclient/net/base.py 85.71% 2 Missing :warning:
nebula3/gclient/net/Connection.py 66.66% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #338 +/- ## ========================================== - Coverage 76.88% 75.63% -1.26% ========================================== Files 18 19 +1 Lines 2514 2647 +133 ========================================== + Hits 1933 2002 +69 - Misses 581 645 +64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wey-gu commented 5 months ago

Thanks!!!! This'll fix pain in our ass of pylance/pyright typing warnings on downstream projects(Yes GenAI Suite!).

LGTM, but on the safe side, due to ci dependency on nebula-ent side(master branch T__T), I'll manually verify build with this branch and come back afterward :-D