vesoft-inc / nebula-python

Client API of Nebula Graph in Python
194 stars 76 forks source link

feat: cast params #349

Closed wey-gu closed 4 months ago

wey-gu commented 4 months ago

To cast param map from primitive to thrift bytes

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number: #273

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 52.63158% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 75.02%. Comparing base (08e6e93) to head (954f33a). Report is 1 commits behind head on master.

Files Patch % Lines
nebula3/gclient/net/base.py 52.63% 18 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #349 +/- ## ========================================== - Coverage 75.36% 75.02% -0.34% ========================================== Files 19 19 Lines 2667 2707 +40 ========================================== + Hits 2010 2031 +21 - Misses 657 676 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wey-gu commented 4 months ago
BeautyyuYanli commented 4 months ago

Some changes:

wey-gu commented 4 months ago

Some changes:

  • method BaseExecutor.execute_py_params to use this feature

  • not support list and dict yet

It's fair to separate the two for performance concern ๐Ÿ‘.

But why not support List? That's actually my initial motivation of such change๐Ÿ˜‹๐Ÿ˜‚

BeautyyuYanli commented 4 months ago

But why not support List? That's actually my initial motivation of such change๐Ÿ˜‹๐Ÿ˜‚

The current usage for NList is wrong and I do not yet find the correct way to use NList

wey-gu commented 4 months ago

Aha, got it, :-p

Should be somewhere I made it wrong, but this was verified working, I'll continue this part later when I have some time.

BeautyyuYanli commented 4 months ago

fixed NList