Closed wey-gu closed 6 months ago
Attention: Patch coverage is 52.63158%
with 18 lines
in your changes are missing coverage. Please review.
Project coverage is 75.02%. Comparing base (
08e6e93
) to head (954f33a
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
nebula3/gclient/net/base.py | 52.63% | 18 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Some changes:
BaseExecutor.execute_py_params
to use this featureSome changes:
method
BaseExecutor.execute_py_params
to use this featurenot support list and dict yet
It's fair to separate the two for performance concern ๐.
But why not support List? That's actually my initial motivation of such change๐๐
But why not support List? That's actually my initial motivation of such change๐๐
The current usage for NList is wrong and I do not yet find the correct way to use NList
Aha, got it, :-p
Should be somewhere I made it wrong, but this was verified working, I'll continue this part later when I have some time.
fixed NList
To cast param map from primitive to thrift bytes
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #273