fix possible graph coredump when metadata refresh during certain query invoke ScanEdgeProcessor::checkAndBuildContexts especially in asan binary - Githubissues

vesoft-inc / nebula

A distributed, fast open-source graph database featuring horizontal scalability and high availability

https://nebula-graph.io

Apache License 2.0

10.89k stars 1.21k forks source link

fix possible graph coredump when metadata refresh during certain query invoke ScanEdgeProcessor::checkAndBuildContexts especially in asan binary #5855

Closed mo-avatar closed 7 months ago

mo-avatar commented 7 months ago

fix possible graph coredump when metadata refresh during certain query invoke ScanEdgeProcessor::checkAndBuildContexts especially in asan binary

What type of PR is this?

[x] bug
[ ] feature
[ ] enhancement

What problem(s) does this PR solve?

Issue(s) number: https://github.com/vesoft-inc/nebula/issues/5854

Description: fix possible graph coredump when metadata refresh during certain query invoke ScanEdgeProcessor::checkAndBuildContexts especially in asan binary

How do you solve it?

return the ret when it is not succeeded

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

[ ] Unit test(positive and negative cases)
[ ] Function test
[ ] Performance test
[ ] N/A

Affects:

[ ] Documentation affected (Please add the label if documentation needs to be modified.)
[ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
[ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
[ ] Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

CLAassistant commented 7 months ago

All committers have signed the CLA.

Salieri-004 commented 7 months ago

LGTM. Thanks for your help～