fix round(5) crash, check type error - Githubissues

vesoft-inc / nebula

A distributed, fast open-source graph database featuring horizontal scalability and high availability

https://nebula-graph.io

Apache License 2.0

10.88k stars 1.21k forks source link

fix round(5) crash, check type error #5967

Closed leaout closed 2 weeks ago

leaout commented 3 weeks ago

What type of PR is this?

[ ] bug
[ ] feature
[ ] enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

return round(5) crash

How do you solve it?

add type check

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

[ ] Unit test(positive and negative cases)
[ ] Function test
[ ] Performance test
[ ] N/A

Affects:

[ ] Documentation affected (Please add the label if documentation needs to be modified.)
[ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
[ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
[ ] Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

CLAassistant commented 3 weeks ago

All committers have signed the CLA.

Salieri-004 commented 2 weeks ago

@leaout Please sign Contributor License Agreement

leaout commented 2 weeks ago

@leaout Please sign Contributor License Agreement

License is ok

Salieri-004 commented 2 weeks ago

@leaout Could you check this page?

leaout commented 2 weeks ago

@leaout Could you check this page?

User name And email address had error， first commit message was not to be modified，what should I do？

Salieri-004 commented 2 weeks ago

@leaout Could you check this page?

User name And email address had error， first commit message was not to be modified，what should I do？

Could you roll back and recommit it?