vespa-engine / pyvespa

Python API for https://vespa.ai, the open big data serving engine
https://pyvespa.readthedocs.io/
Apache License 2.0
79 stars 24 forks source link

Add auth_clients to `ContainerCluster` #814

Closed thomasht86 closed 1 week ago

thomasht86 commented 1 week ago

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Fixes #811 by adding auth_clients as a param to ContainerCluster. If auth_clients are passed to ApplicationPackageand cluster(s) with auth_clients are defined, and they differ, the auth_clients passed to ApplicationPackage will override those passed to the Cluster.

Feel like we are moving a bit way from the jinja-template approach now, by moving more to the classes of the elements. Would appreciate perspective on whether we should attempt to move back more towards jinja-template.

Triggered cloud integration-tests from local, and all passed. ✅