search

vespa-engine / vespa_exporter

Vespa metrics exporter for Prometheus
Apache License 2.0
6 stars 5 forks source link

Add more robustness to the exporter #2

Closed dkurzaj closed 6 years ago

dkurzaj commented 6 years ago

When using the exporter I realized it would crash if some of the nodes listed in the cluster controller were down. So I removed the raise to not crash anymore, so that the exporter is still able to send the metrics of the other nodes still up. I also realized that if the cluster controller went down, the exporter would raise and crash too. I changed this behaviour so that it would keep trying to get the metrics from the last known nodes and only stop if it does not know any node of the cluster.

yahoocla commented 6 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

dkurzaj commented 6 years ago

CLA signed :)

bratseth commented 6 years ago

@zoyvind please review

zoyvind commented 6 years ago

Better error-handling was just what this script needed. Nice work! :)

bratseth commented 6 years ago

👍