search

vesperin / vesper

source code curation library for Java 1.6 and above
1 stars 0 forks source link

Code clean up and restructuring #39

Closed hsanchez closed 9 years ago

hsanchez commented 9 years ago

plus updates to code summarization logic

hsanchez commented 9 years ago

@Chandranil2606 (only if you 20 minutes or so), can you review this pull request? this may help you understand the code base. Please let me know if you can't.

Chandranil2606 commented 9 years ago

I am going out today. I can check it tomorrow morning. Will that be okay?

On Fri, Jan 23, 2015 at 1:48 PM, Huascar Sanchez notifications@github.com wrote:

@Chandranil2606 https://github.com/Chandranil2606 (only if you 20 minutes or so), can you review this pull request? this may help you understand the code base. Please let me know if you can't.

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71272142.

hsanchez commented 9 years ago

Sure

— Sent from my iPhone

On Fri, Jan 23, 2015 at 3:19 PM, Chandranil2606 notifications@github.com wrote:

I am going out today. I can check it tomorrow morning. Will that be okay? On Fri, Jan 23, 2015 at 1:48 PM, Huascar Sanchez notifications@github.com wrote:

@Chandranil2606 https://github.com/Chandranil2606 (only if you 20 minutes or so), can you review this pull request? this may help you understand the code base. Please let me know if you can't.

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71272142.

Reply to this email directly or view it on GitHub: https://github.com/hsanchez/vesper/pull/39#issuecomment-71283474

hsanchez commented 9 years ago

@Chandranil2606, would you be able to review it? please let me know.

Chandranil2606 commented 9 years ago

I am yet to come back home. Sorry, will review it as soon as I get back.

On Sat, Jan 24, 2015 at 12:25 PM, Huascar Sanchez notifications@github.com wrote:

@Chandranil2606 https://github.com/Chandranil2606, would you be able to review it? please let me know.

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71335663.

Chandranil2606 commented 9 years ago

I am trying to access this but I am getting a 404 error. I think I don't have access to it yet.

https://github.com/hsanchez/vesper/pull/39

On Sat, Jan 24, 2015 at 2:50 PM, Chandranil Chakraborttii <cchakrab@ucsc.edu

wrote:

I am yet to come back home. Sorry, will review it as soon as I get back.

On Sat, Jan 24, 2015 at 12:25 PM, Huascar Sanchez < notifications@github.com> wrote:

@Chandranil2606 https://github.com/Chandranil2606, would you be able to review it? please let me know.

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71335663.

hsanchez commented 9 years ago

@Chandranil2606 this is strange because you are a collaborator of the project.

Access my vesper repo. then click on pull requests. that should do the trick.

hsanchez commented 9 years ago

@Chandranil2606 you must have access, you forked the project. therefore u must have access it.

hsanchez commented 9 years ago

@Chandranil2606, I will handle the PR myself. I will review it and then merge it if ok.

Can you meet tomorrow via skype to see if we can fix this access problem?

Chandranil2606 commented 9 years ago

We can meet after 5pm today. We can also meet on campus after 12:30 pm tomorrow.

Regards, Chandranil

On Sun, Jan 25, 2015 at 10:53 PM, Huascar Sanchez notifications@github.com wrote:

@Chandranil2606 https://github.com/Chandranil2606, I will handle the PR myself. I will review it and then merge it if ok.

Can you meet tomorrow via skype to see if we can fix this access problem?

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71420536.

hsanchez commented 9 years ago

ok. let’s make it a 510pm; via Skype. ttyl.

BTW, did you talk to your friends about experiment?

Cheers Huascar A. Sanchez

On Jan 26, 2015, at 11:36 AM, Chandranil2606 notifications@github.com wrote:

We can meet after 5pm today. We can also meet on campus after 12:30 pm tomorrow.

Regards, Chandranil

On Sun, Jan 25, 2015 at 10:53 PM, Huascar Sanchez notifications@github.com wrote:

@Chandranil2606 https://github.com/Chandranil2606, I will handle the PR myself. I will review it and then merge it if ok.

Can you meet tomorrow via skype to see if we can fix this access problem?

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71420536.

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71522803.

Chandranil2606 commented 9 years ago

Okay. The timing works fine for me. I have asked a few of my friends and around 5 people have confirmed they will help me. Will ask more friends as well.

Regards, Chandranil

On Mon, Jan 26, 2015 at 11:37 AM, Huascar Sanchez notifications@github.com wrote:

ok. let’s make it a 510pm; via Skype. ttyl.

BTW, did you talk to your friends about experiment?

Cheers Huascar A. Sanchez

On Jan 26, 2015, at 11:36 AM, Chandranil2606 notifications@github.com wrote:

We can meet after 5pm today. We can also meet on campus after 12:30 pm tomorrow.

Regards, Chandranil

On Sun, Jan 25, 2015 at 10:53 PM, Huascar Sanchez < notifications@github.com> wrote:

@Chandranil2606 https://github.com/Chandranil2606, I will handle the PR myself. I will review it and then merge it if ok.

Can you meet tomorrow via skype to see if we can fix this access problem?

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71420536.

— Reply to this email directly or view it on GitHub < https://github.com/hsanchez/vesper/pull/39#issuecomment-71522803>.

— Reply to this email directly or view it on GitHub https://github.com/hsanchez/vesper/pull/39#issuecomment-71523049.

hsanchez commented 9 years ago

LGTM