search

vesse / node-ldapauth-fork

Simple node.js module to authenticate against an LDAP server
Other
127 stars 79 forks source link

upgrade ldapjs to 3.0.4 #106

Closed BalzGuenat closed 5 months ago

BalzGuenat commented 1 year ago

This is an initial effort to upgrade the ldapjs dependency to version 3.

Version 3 breaks this package, so some changes are necessary (see ldapjs release notes).

I've tested these changes with a fairly simple setup incl. groups. More comprehensive tests by someone with a slightly more complex use case are probably a good idea.

I have removed the includeRaw feature, as ldapjs no longer supports it. Binary attributes are handled differently now.

Feel free to build upon or take only parts of this PR if you are only happy with some parts of it.

xelandreb commented 1 year ago

Thanks. Hope this MR will be merge soon.