search

vesse / node-ldapauth-fork

Simple node.js module to authenticate against an LDAP server
Other
127 stars 79 forks source link

Make LdapAuth an EventEmitter #41

Closed johncylee closed 7 years ago

johncylee commented 8 years ago

An 'error' event emitted from ldapjs will be thrown because there is no listener. Make LdapAuth an EventEmitter so these events can be handled properly.

This approach is similar to

https://github.com/vesse/node-ldapauth-fork/pull/20#issuecomment-113585682

If reconnect is set, ldapjs will automatically retry so the error handler can simply output some logs.

Related issues: #25 , #39

Nighthawk22 commented 8 years ago

Hi! When will this pull request be merged? We need this fix really urgently. Thanks.

chriswininger commented 8 years ago

yeah this feature would be great currently biting me, kind of sucks to have a server crash just because ldap is down when someone tries to authenticate

mhoffmeyerDC commented 7 years ago

CC: @vesse

Any reasons for holding out on this PR? Anything we can do to help?

dbenchi commented 7 years ago

Can you please explain us why such PR is not yet merged? Thanks a lot