search

vesse / node-ldapauth-fork

Simple node.js module to authenticate against an LDAP server
Other
127 stars 79 forks source link

add username to groupSearchFilter #66

Closed velrest closed 6 years ago

velrest commented 6 years ago

Sorry it took so long. I totally forgot about #62 . I checked the test ldap server you're using in your test but no posixGroup exists with the attribute memberUid which i could test. Also i have no idea of TypeScript and dont know if i have to edit the header file but i dont think so.

I hope this helps someone else!

vesse commented 6 years ago

You are not the only one who forgets stuff - I too have completely forgotten this. Could you add a note about the {{username}} replacement in group search filter to the README. Technically would be nice to have the property used (now hardcoded uid) as configurable value too but since no-one has asked about this earlier probably good enough for now, and if someone needs to be able to use different property than uid they can create a PR