search

vesse / node-ldapauth-fork

Simple node.js module to authenticate against an LDAP server
Other
127 stars 79 forks source link

Add starttls option #70

Closed ehlertjd closed 4 years ago

ehlertjd commented 5 years ago

This adds a boolean starttls option which, if set, will execute starttls before binding, emitting an error should the TLS setup process fail.

Closes #59

vesse commented 5 years ago

Thanks, and sorry for the wait :( I merged vesse/node-ldapauth-fork#71 which fixes the admin bind being executed twice, and now your PR is conflicting. Do you have time to check the merge conflict? I could do that myself since I've been busy or lazy, but I don't have a TLS server at hand with which I could really test how this works.

shaozi commented 4 years ago

@vesse Can we merge this PR?