search

vesse / node-ldapauth-fork

Simple node.js module to authenticate against an LDAP server
Other
127 stars 79 forks source link

moment.js dependency #74

Closed onhate closed 5 years ago

onhate commented 5 years ago

I noticed my application is including moment.js as indirect dependency and it's coming from ldapauth-fork package, I've read the code and didn't find a usage of moment in this repository, is this dependency needed? considering it's 370Kb it would be good to remove.

vesse commented 5 years ago

Hmm true, wonder how that got there. I'll remove the direct dependency but it wont matter much since ldpajs requires bunyan and it requires moment, so it will be installed anyways.

vesse commented 5 years ago

Removed from 4.1.1