search

vesse / node-ldapauth-fork

Simple node.js module to authenticate against an LDAP server
Other
127 stars 79 forks source link

LdapAuth.prototype.close callback not called #75

Closed FranckFreiburger closed 5 years ago

FranckFreiburger commented 5 years ago

https://github.com/vesse/node-ldapauth-fork/blob/f4f9f30c7e5986cd647f03384ca7e9b1f7fbee15/lib/ldapauth.js#L155-L157

AFAICS, it seems that you are waiting for a callback that will never be called ? See: https://github.com/joyent/node-ldapjs/blob/master/lib/client/client.js#L844-L847

vesse commented 5 years ago

The callback is passed to Client.prototype._send and from there to Client.prototype._sendSocket. Then it becomes little unclear to follow without getting deeper into the implementation, but if you eg. add logging to close callback in passport-ldapauth and run the tests you'll see the callback is called.

FranckFreiburger commented 5 years ago

Thank you for the clarification