vessillo / foxreplace

Automatically exported from code.google.com/p/foxreplace
0 stars 0 forks source link

Importing a JSON file with syntax errors fails without warning of the syntax error #117

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Using a .Json file to import a substitution list works great up to 225 
substitutions (single substitution list to import).

Import is ignored for .json files containing more than 225 substitutions (one 
list). Pressing import simply result in no reaction from the application (as if 
I had not pressed import).

I am looking to replace up to 3000 input values (phone numbers replaced by real 
names).

Would be awesome if you could fix this...
What version of the product are you using? On what operating system?

Cheers
Luke
PS: not posting my file as that has real numbers/names and I lack the time to 
create a mockup data file with so many distinct entries. If that is required, I 
will provide it... but first want to check if this is a known limitation.

Original issue reported on code.google.com by ronald.b...@gmail.com on 17 Jul 2013 at 3:53

GoogleCodeExporter commented 9 years ago
sorry forgot to remove some of the predefined questions.
Product: 0.14.0
OS: Win7

Original comment by ronald.b...@gmail.com on 17 Jul 2013 at 3:56

GoogleCodeExporter commented 9 years ago
Hi, I have created a file with 10000 substitutions using a script and I can 
import it. I have tried putting each substitution in a different group and also 
with all in the same group (I don't understand what you mean with "single 
substitution list"), and it works both ways.

So the problem is not the number of entries. I don't know if it could be the 
file size, my test file is 1.5 MB.

If you could provide a file with which the problem happens, it would be helpful.

Also, you say that pressing import has no reaction. I suppose you mean pressing 
the open button after selecting the file in the dialog. Is this correct?

Original comment by marc.r...@gmail.com on 18 Jul 2013 at 9:09

GoogleCodeExporter commented 9 years ago
Thx for the quick answer, i will come up with a test file.

By "No reaction" I really mean zero reaction, as if the "Import" button simply 
had no functionality associated with it. I dont even get the usual prompt to 
Overwrite/Append.

Original comment by ronald.b...@gmail.com on 18 Jul 2013 at 9:59

GoogleCodeExporter commented 9 years ago
Sorry, I need to correct myself. Yes, no reaction after confirming the file 
using "Open" button in the file dialog.

Original comment by ronald.b...@gmail.com on 18 Jul 2013 at 10:03

GoogleCodeExporter commented 9 years ago
Issue is reproduceable. Basically the error seems to be violation of the JSON 
syntax, but there is no explicit error message.

File 1 - "illegal" comma after the last input/output element.
File 2 - non-escaped char. E.g. .....\" as an output element needs to be 
properly escaped as .....\\"

Removing those errors actually now allows me to import the 3000 entries.

Cheers
Luke

Original comment by ronald.b...@gmail.com on 18 Jul 2013 at 12:46

Attachments:

GoogleCodeExporter commented 9 years ago
With the attached files now I can reproduce the issue. There's a SyntaxError 
thrown by the JSON parser but I don't catch it, that's why there's no error 
message and it only appears in the error console. I will change the issue 
summary to reflect this. Thanks for the report!

Original comment by marc.r...@gmail.com on 18 Jul 2013 at 3:13

GoogleCodeExporter commented 9 years ago
Issue 120 has been merged into this issue.

Original comment by marc.r...@gmail.com on 24 Aug 2013 at 5:09

GoogleCodeExporter commented 9 years ago

Original comment by marc.r...@gmail.com on 17 Jun 2014 at 4:45