vessillo / foxreplace

Automatically exported from code.google.com/p/foxreplace
0 stars 0 forks source link

Make options dialog non-modal #98

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It is common in Windows dialogues to have an "Apply" button in addition to the 
"OK" button.

Please can you consider adding this button because exiting FoxReplace option 
and then re-entering is cumbersome when experimenting?

Original issue reported on code.google.com by sqgl2...@gmail.com on 5 Jan 2013 at 11:58

GoogleCodeExporter commented 9 years ago
In Windows the options dialog now has only a close button. So, making the 
dialog non-modal would be enough.

Original comment by marc.r...@gmail.com on 5 Jan 2013 at 1:55

GoogleCodeExporter commented 9 years ago

Original comment by marc.r...@gmail.com on 19 May 2013 at 6:45

GoogleCodeExporter commented 9 years ago

Original comment by marc.r...@gmail.com on 19 May 2013 at 6:45

GoogleCodeExporter commented 9 years ago
Correction to comment #1: the close button appears instead of ok/close when 
browser.preferences.instantApply is true.

Take into account browser.preferences.instantApply, <prefwindow>.instantApply, 
and <preference>.instantApply. Take into account issue 66 and issue 100.

In the last version, changes to the substitution list are always instant, 
independently of the setting (this can be considered a bug).

Original comment by marc.r...@gmail.com on 19 May 2013 at 11:13

GoogleCodeExporter commented 9 years ago
Fixed in r205: the new behaviour is the same as the main Firefox options window:
- if browser.preferences.instantApply is true, then the dialog is non-modal, 
has only a Close button and the changes are applied instantly
- if browser.preferences.instantApply is false, then the dialog is modal, has 
OK and Cancel buttons and the changes are applied when OK is pressed

Original comment by marc.r...@gmail.com on 1 Aug 2013 at 4:47