search

vesta-webtrees-2-custom-modules / vesta_classic_laf

Vesta Classic Look & Feel (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
17 stars 2 forks source link

2.1.10.0.0 - Compact layout for edit dialogs does not work with Rural theme #106

Closed TheDutchJewel closed 1 year ago

TheDutchJewel commented 1 year ago

Control panel / Modules / ⚶ Vesta Classic Look & Feel / Preferences / Edit dialogs / Use compact layout

"Display all edit dialogs using a more compact layout, which also omits the standard header and footer. This only affects standard and specific custom themes."

In webtrees v2.0.x the compact layout for the edit dialogs works fine with Rural theme.

But in webtrees v2.1.10 it doesn't work anymore with the Rural Theme.

Is it possible to fix this?

Tested with:

ric2016 commented 1 year ago

It is certainly possible (although it is always tricky to align separate custom modules), but I'm not sure anymore whether it's a good idea in general to adjust the layout of custom themes.

This has been discussed a bit here. I think after that I decided to not adjust the Rural theme edit dialogs any more. Still not sure about this.

TheDutchJewel commented 1 year ago

I think after that I decided to not adjust the Rural theme edit dialogs any more. Still not sure about this. ric2016 closed this as completed

This is very unfortunate. Especially the lack of the compact layout for the edit dialog in the Rural theme is a big miss. Using the default webtrees themes for data entry is not an option because they use too much screen area.

Is it possible to apply the changes for the editing dialog in the Rural theme through the CSS module?

If so, how?

ric2016 commented 1 year ago

Using the default webtrees themes for data entry is not an option because they use too much space.

I don't understand this part, 'compact layout' is supposed to address this?

ric2016 commented 1 year ago

Is it possible to apply the changes for the editing dialog in the Rural theme through the CSS module?

This seems to work (similar for footer), may have to be extended for specific dialogs:

body[class~="wt-route-EditFactPage"] > header {
  display: none;
}
TheDutchJewel commented 1 year ago

Using the default webtrees themes for data entry is not an option because they use too much space.

I don't understand this part, 'compact layout' is supposed to address this?

I actually meant to say that using a standard webtrees theme with the Vesta Classic LAF option compact layout for Edit dialogs for just entering data is not an option because those themes take up way too much image space for displaying data.

The Rural theme shows everything much more compactly than the standard webtrees themes.

TheDutchJewel commented 1 year ago

body[class~="wt-route-EditFactPage"] > header { display: none; }

Thanks, this works fine!