search

vesta-webtrees-2-custom-modules / vesta_classic_laf

Vesta Classic Look & Feel (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
17 stars 2 forks source link

Runtime exception in combination with justlight-2.2.8 #152

Closed webtrees-pesz closed 2 months ago

webtrees-pesz commented 2 months ago

Hello Richard,

I opened an issue for jc-justlight-2.2.8 (See https://github.com/JustCarmen/webtrees-theme-justlight/issues/173)

Carmen replied: This looks like an issue with Vesta. In this version of the theme I've split up the cellphone menu into two separate menus. The primary (genealogy) and the secondary (user) menu. The file navbar-toggler doesn't exist anymore in this version. You should raise an issue at https://github.com/vesta-webtrees-2-custom-modules/vesta_classic_laf/issues

Best regards, Peter

ric2016 commented 2 months ago

This looks like an issue with Vesta

The basic issue is that different custom modules may conflict if they modify the same view. Vesta attempts to handle this conflict, which is problematic in particular if there are frequent changes in the other module. The fix itself is easy in this case, but I may have to restrict the handling to specific justLight versions if there are further changes in the theme.