search

vesta-webtrees-2-custom-modules / vesta_classic_laf

Vesta Classic Look & Feel (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
17 stars 2 forks source link

Fix #66 - Missing icons in Justlight theme #67

Closed JustCarmen closed 2 years ago

JustCarmen commented 2 years ago

Make default view for Justlight theme depend on internal name in stead of support url

See: https://github.com/JustCarmen/webtrees-theme-justlight/issues/102

I've changed the support url for this theme. Since this change the footer scripts are not loaded correctly. I think it is better use the internal name in stead of the support url.

ric2016 commented 2 years ago

Thank you for determining the cause of this bug!

The problem with this approach (thus the comment in the code 'we need a way to identify it regardless of its folder name;') is that it breaks if a user renames the folder.

Therefore I decided to use a field that I expected to be more stable, which turns out not to be the case ;-) I don't see a solution that is guaranteed to work in all cases here.

JustCarmen commented 2 years ago

I don't see a solution that is guaranteed to work in all cases here.

Me neither, but I think I won't rename the folder in the near future :). It sounds more logic to use the internal (folder) name than the support url.

I've done the same thing with the Fancy Imagebar which I support from the Justlight theme. I am aware of the fact that renaming folders has consequences, but I wasn't aware of the fact that changing the support url has consequences too.

ric2016 commented 2 years ago

Me neither, but I think I won't rename the folder in the near future :)

It wasn't intended to protect against that - But unfortunately the webtrees admin himself may rename custom module folders for some reason. That doesn't break anything within a custom module, except such internal checks.

For now, I'll stick with the support url, at least the webtrees admin cannot meddle with that ;-)