vesta-webtrees-2-custom-modules / vesta_common

⚶ Vesta Common (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
8 stars 3 forks source link

LONG/LATI: Problem when mixed Event/LOC data #100

Closed ungeahnt closed 1 year ago

ungeahnt commented 1 year ago

When I add LONG/LATI coordiantes directly to an birth place (E8 and N45) which also has LOC coordinates (N48.9833 and E9.45873), then I see the number of the map icons increased from 4 to 7 and all icons are linked only to the birth place LONG/LATI coordinates (see red marking in the screenshot below and here: Birth Place)

-> There should be only 4 map icons (linked to the birth place).

grafik

Link to the LOC data: https://proavitus.de/tree/proavitus/sharedPlace/X81/Oppenweiler

Additionally the url from the first bing icon includes strange html code:

https://www.bing.com/maps/?v=2&cp=45~8&lvl=10&dir=0&sty=o&sp=point.45_8_ — <span class="error" title="Unbekannter GEDCOM Code">_DUMMY:EVEN</span>

ric2016 commented 1 year ago

You have configured 'duplicate' map link providers, namely webtrees default providers and Vesta providers.

See Control panel > All modules > Map links.

When using Vesta, it is recommended to disable the webtrees map link providers (which only work with direct lat/long on the fact itself anyway, therefore you usually don't see them).

Still, the fact used to generated the urls is actually modified by Vesta. This causes the broken url in the webtrees Bing map link, I'll have to fix this part.

ungeahnt commented 1 year ago

When using Vesta, it is recommended to disable the webtrees map link providers

Thanks for the explanation and sorry for the circumstances. I've deactivated the other modules an it works now as expected.

So, the map links are an integral part of the vesta_personal_fact module? I was not aware of this. I've thought that the module provides only the icons and the functionality is still included in the 'original' map links modules.

I'll just close here. I'm in the wrong repo anyway ;)

ric2016 commented 1 year ago

You can still use the original map link modules, but they won't show links for indirect locations (from _LOC/_GOV, strangely not even from webtrees locations), only for lat/long on the fact itself.

I could actually change the implementation in the enhanced facts & events tab and provide 'enhanced' facts to these original map link modules. I'll have to think about that ...

The Vesta map links have additional configuration options though. Overall this is all a bit of a mess (webtrees 1.x didn't have the map link modules at all, so this may need some cleanup).

I'll transfer and reopen this issue in order to handle the 'broken url' part.

ric2016 commented 1 year ago

Bing broken url: Fixed in Vesta release 2.1.16.0.0.