vesta-webtrees-2-custom-modules / vesta_common

⚶ Vesta Common (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
8 stars 3 forks source link

Entry of shared place not possible in specific situation in SOUR:DATA:EVEN:PLAC #105

Closed Jefferson49 closed 1 year ago

Jefferson49 commented 1 year ago

Observed with webtrees 2.1.16 and vesta Shared Places 2.1.16.1.6.

If using a wrong date range in SOUR:DATA:EVEN:DATE (in this example: FROM 1885 TO 1818), vesta shared places does not allow to select an existing shared place. In the example below, the shared place "Fehrbellin, Landkreis Ostprignitz-Ruppin, Brandenburg, DEU", exists in the webtrees tree, but is not found for selection.

Of course, this is a very special situation and no high priority to fix. However, it is interesting that the error message from vesta-webtrees-2-custom-modules/vesta_shared_places#154 is generated in this case. In this situation, the error message in the logs is reproducible. However, it is probably not the only root cause for the error message, because I (hopefully) do not use wrong date ranges more frequently.

Eingabe Shared Place nicht möglich bei Quellen

I also attach a stack trace of the error in the webtrees error logs (Control panel / Website logs), and a GEDCOM snipped for the source.

Stack Trace.txt Gedcom SOUR.ged.txt

ric2016 commented 1 year ago

Apparently date ranges where the end is earlier than the beginning are not handled consistently internally. I'll probably just skip the 'TO' part in cases like these (alternative would be to ignore it altogether).

In an case this should indeed help to determine the cause of vesta-webtrees-2-custom-modules/vesta_shared_places#154.