search

vesta-webtrees-2-custom-modules / vesta_extended_relationships

⚶ Vesta Extended Relationships (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
11 stars 4 forks source link

Access level for charts #119

Open SnarfW opened 1 year ago

SnarfW commented 1 year ago

I would like to hide the charts in the 'more charts menu' for visitors. According to the instructions this should be possible via Control Panel > Charts Unfortunately, the charts are always shown, even when I set the access level to 'Hide from everyone'. Is this a bug, or is something in my set-up hampering this to function correct? I also see only one menu, I was expecting to see an option to set the access per chart.

afbeelding

I did now hide them all by setting the access level for the menu (Control Panel > Menu), which is working as expected

Using vesta 2.1.17.0.3 Webtrees 2.1.17

ric2016 commented 1 year ago

These options are only for the original relationships chart.

The new charts are experimental and will be fully customizable as soon as webtrees supports container modules, see here .

Unfortunately there is no progress at all on this issue (and many others), and no indication whether this will change. It may help if you leave a comment for that issue, but I'm not optimistic that further custom module support is on the roadmap at all.

SnarfW commented 1 year ago

You mentioned that the new charts are experimental, I wasn't aware. They are include in your 'stable' release zip-file from your homepage. Wouldn't it be better not to include them (yet) in the zip?

I also see that there are many open issue for webtrees...

ric2016 commented 1 year ago

Wouldn't it be better not to include them (yet) in the zip?

I optimistically was hoping that webtrees development would speed up again. I still think it's ok to include them as the extra menu can be hidsden altogether, as you found out. I may have to reconsider this if the webtrees development hiatus continues.

kiwi3685 commented 7 months ago

As a temporary fix, to enable removing the "More charts" menu item while keeping the original relationships chart available, could you just add a new class to the menu item.

Like: return new Menu( I18N::translate('More Charts'), '#', 'menu-chart more-charts', ['rel' => 'nofollow'], $submenus->all());

Then "display:none; can be added in css by anyone who wants this option. Perhaps preferable than you removing these charts completely.

ric2016 commented 7 months ago

Please support the container modules issue in webtrees to get this fixed properly.

You don't need css to hide the extra menu though: Just set its access level in the control panel to "hide from anyone". It may seem, due to the name, that this would affect the entire module, but it actually only affects the menu part.

kiwi3685 commented 7 months ago

I trued that before I made the suggestion. It also removed the Relationship chart link from the main Charts menu group. I can check it again tomorrow if you’re sure it should work.

ric2016 commented 7 months ago

Yes, this works, I just re-checked myself. Make sure to set the access level under Modules > Genealogy > Menus > Vesta Extended Relationships (and keep 'Enabled' checked).

kiwi3685 commented 6 months ago

Thank you. Now I see the problem.

I was changing access to the item "Modules > Genealogy > Charts > Vesta Extended Relationships".

I should have known better.

ric2016 commented 6 months ago

Well it is a bit confusing because the extra menu also contains charts. It really would be much simpler with container modules.