search

vesta-webtrees-2-custom-modules / vesta_research_suggestions

⚶ Vesta Research Suggestions (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
5 stars 3 forks source link

translation update - fix untranslated string #47

Closed HerzScheisse closed 6 months ago

HerzScheisse commented 6 months ago

Hi,

I hope this is the right way and i didnt do anything wrong...

I've found a untranslated string and first tried to translate it via weblate... but it was not there... so I started to search through some files... in the end I didn't found any occurrences of that string, so i added it...

I cant find the origin of the untranslated version, so i just updated the line number for the "Research Suggestions" plural-version

Some other edits like formating in this PR is from POEdit... feel free to delete them...

"Research Suggestion" is used in shared places -> history of place

ric2016 commented 6 months ago

These files are auto-generated from code and any direct change would be overwritten later.

Anyway, if the source string isn't managed in webtrees (via I18N::translate), it won't help to add a translation.

Where does this string "Research Suggestion" show up? Do you have a screenshot? I only see this, but apparently that's only used internally.

HerzScheisse commented 6 months ago

okay thanks for explaining... in case this PR is useless feel free to delete it and add these modifications in any other prefered way...

yeah i cant find it in any other file too... so i added it and it's now translated...

transl research suggestion its used in the shared place page under the last tab...

BUT while searching for this again i stumpled upon another untranslated string: transl gov hierachy

GOV Hierarchy should be translated too...

Hope these screenshots help to lacated the problem

ric2016 commented 6 months ago

Thank you for the screenshots, I forgot about the place history. I'll add "Research Suggestion" and "GOV Hierarchy" as translatable strings in the respective modules.

so i added it and it's now translated...

I see - that works by chance in this specific case because webtrees makes all fact labels 'dynamically' translatable, this is intended to allow users to use their own EVEN types.

ric2016 commented 6 months ago

The new strings are now available in weblate.

Ich könnte ja Deutsch auch mal selber übersetzen, aber ich halte mich da grundsätzlich raus ;-) (Ich benutze selber lieber die englische Version von webtrees, deswegen fallen mir solche Stellen regelmäßig auch nicht auf)