vesta-webtrees-2-custom-modules / vesta_shared_places

⚶ Vesta Shared Places (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
13 stars 3 forks source link

No possibility to enter _LOC:NAME:ABBR:TYPE #145

Closed Jefferson49 closed 1 year ago

Jefferson49 commented 1 year ago

Observed with vesta 2.1.15.0.3 and webtrees 2.1.15

There seems to be no possibility to enter data for _LOC:NAME:ABBR:TYPE. even if "Edit with all GEDCOM tags" is chosen.

_LOC ABBR TYPE

From the Addendum specification, it should be available:

0 @<XREF:_LOC>@ _LOC {1:1}
1 NAME <PLACE_NAME> {1:M}
2 DATE <DATE_VALUE> {0:1}
2 ABBR <ABBREVIATION_OF_NAME> {0:M}
3 TYPE <TYPE_OF_ABBREVIATION> {0:1}

For existing data, the abbreviation is shown correctly:

_LOC ABBR TYPE existing

I do not know if this is missing in the GEDCOM-L tag customization in webtrees, or if it is missing in vesta shared places.

ric2016 commented 1 year ago

It's missing in webtrees, here:

That line should be '_LOC:NAME:ABBR' => new CustomElement(I18N::translate('Abbreviation'), ['TYPE' => '0:1']),

Jefferson49 commented 1 year ago

ok, thank You very much for analyzing. I will file an issue in webtrees

ric2016 commented 1 year ago

I see this has been handled already in webtrees (https://github.com/fisharebest/webtrees/pull/4725), therefore I'll close here.

Jefferson49 commented 1 year ago

yes, instead of opening an issue, I directly started a pull request with the proposed code, and Greg already accepted :-)