search

vesta-webtrees-2-custom-modules / vesta_shared_places

⚶ Vesta Shared Places (Webtrees 2 Custom Module)
https://cissee.de/
GNU General Public License v3.0
13 stars 3 forks source link

CodeStyle - remove whitespaces #174

Closed HerzScheisse closed 7 months ago

HerzScheisse commented 8 months ago

for quite a while now i wanted to submit these code style changes... now while i'm updating my webtrees i used the chance to do it right away...

hope this is helpfull...

If you want, i can do this for the other modules too...

ric2016 commented 8 months ago

If you want, i can do this for the other modules too...

Let me check whether there is an option for this in my IDE (NetBeans). I'll definitely use the setting to remove trailing whitespace when saving files from now on.

ric2016 commented 7 months ago

Apparently there is no way to batch remove trailing spaces in Netbeans. Did you use a tool/ IDE for this?

HerzScheisse commented 7 months ago

Hey,

Sorry for messing up this PR with my latest commit... I thought you added this already thats why I decided to close this...

For the formatting I was using a extension in Visual Studio Code, its not fully automated... but with the keyboard shortcuts kinda fast...

this is the extension... https://marketplace.visualstudio.com/items?itemName=eetami.whitespace-formatter

If you want and if its practical for you to copy these changes back to your IDE, i can do this for you... and created the PRs for that...

ric2016 commented 7 months ago

I thought you added this already thats why I decided to close this...

No, I just fould the setting to remove trailing whitespace when editing, but no way to do this once for all files.

If there is no way to do this initial cleanup automated, I'm not doing it myself - But I'll accept PRs.