search

vetruvet / laravel-phpredis

Use phpredis as the redis connection in Laravel
Apache License 2.0
43 stars 9 forks source link

L 5.1 issue? #3

Closed nardev closed 9 years ago

nardev commented 9 years ago

Any idea how to fix this???

ErrorException in Database.php line 8: Declaration of Vetruvet\PhpRedis\Database::createAggregateClient() should be compatible with Illuminate\Redis\Database::createAggregateClient(array $servers, array $options = Array)

nardev commented 9 years ago

At the end, it was fixed.

Adding ", array $options = []" as a second parameter in two methods of class Database

PhpRedis\Database.php

protected function createAggregateClient(array $servers, array $options = [])

protected function createSingleClients(array $servers, array $options = [])

hint from: @christophelimpalair

p.s. Please update this changes ASP so that i can do composer update relaxed :dash:

vetruvet commented 9 years ago

Thanks for the fix! Tagged in version 1.0.2.

vrga commented 9 years ago

Your fix has not been picked up by packagist, and released version is stil 1.0.0. Please remove the version tag from your composer.json :) https://github.com/composer/packagist/issues/434

vetruvet commented 9 years ago

Thanks @vrga . version removed from composer.json now