vetter / shoc

The SHOC Benchmark Suite
Other
247 stars 102 forks source link

Invalid "jsrun" failure #71

Open cponder opened 3 years ago

cponder commented 3 years ago

When I run commands like this

bin/shocdriver -p 0 -n 1 -d 0,1 -s 3 -cuda
bin/shocdriver -p 0 -n 1 -d 0,1 -s 3 -opencl

all of the tests fail, and some of the corresponding Log/* files say this

sh: 1: jsrun: not found

I don't get why this is happening, since this is the only reference I can find in the source

783        # check if we're on summit
784        if (index($host, "summit.olcf")) {
785            # summit uses jsrun
786            $command .= "jsrun -n $numTasks -a 1 -c 1 -g $numDevices ";

and the hostname is clearly set differently from "summit.olcf":

Hostname: luna-0063

The problem doesn't show up with single-GPU tests, likely because the launcher is not invoked.

cponder commented 3 years ago

I'm told that

 This is a mistake in their script, index() returns 0 if the names match and -1 otherwise so it should be if ( index() >= 0 ).

and I can see that this change to libexec/driver.pl fixes the problem:

 784c784
 <        if (index($host, "summit.olcf")) {
 ---
 >        if (index($host, "summit.olcf") >= 0) {

Can you please integrate the change?