vevek / pe

0 stars 0 forks source link

HelpWindow not shown as composition, when other Panels/Boxes/Displays are shown to be compositions. #10

Open vevek opened 3 years ago

vevek commented 3 years ago

HelpWindow is not shown as a composition but just as an association, when other Panels/Boxes/Displays are shown to be compositions wrt MainWindow.

This may lead to confusion to readers.

Actual: HelpWindow not shown as composition with MainWindow.

Expected: HelpWindow should be shown as composition with MainWindow.

Screenshot:

Screenshot 2021-04-16 at 15.29.46.png

nus-pe-bot commented 3 years ago

Team's Response

A composition is an association that represents a strong whole-part relationship. When the whole is destroyed, parts are destroyed too i.e., the part should not exist without being attached to a whole.

The HelpWindow can exist on its own and doesn't have to rely on the MainWindow, i.e. it is possible to test the HelpWindow independently without having to instantiate a MainWindow or create a stub in its place. This is therefore an association not a composition. It is because of implementation convenience that HelpWindow is created and stored under the MainWindow.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]