vexchange / info

https://info.vexchange.io
4 stars 1 forks source link

Possible Currency Format Edit for UX/UI of card on low pixel width device. #11

Open brettaio opened 2 years ago

brettaio commented 2 years ago

In Utils/index.js

export const formatCurrency = (num = 0) => numeral(num).format('$0,0.0000')

To

export const formatCurrency = (num = 0) => numeral(num).format('$0,0.00').

**only if this take currency based data in table down to 2 decimal places (for liquidity and volume) saving 4 characters on width. Table is slightly out of view for landscape IPhone 8.

If possible,

Also price format to 6 decimal places to accomodate PLA token price.

OliverNChalk commented 2 years ago

Thanks for the idea @beatsbybre , how do you feel about the following proposal:

Visually: image

brettaio commented 2 years ago

Ohhhh damn. 🔥

brettaio commented 2 years ago

But on smaller device, I'd be weary adding more than you take if price goes up to 8 or more decimals.

Unless spacing drops down to 0.5 rem

brettaio commented 2 years ago

image

OliverNChalk commented 2 years ago

What device are you on, this should be displaying as cards, not as a table. E.g. on mobile each pair should stack vertically instead of sprawling horizontally.

brettaio commented 2 years ago

The good old landscape conundrum. iPhone 8.

Abrasively finding those hard to reach breakpoints haha

OliverNChalk commented 2 years ago

Will assign to @KennethAshley to check mobile breakpoints

brettaio commented 2 years ago

View size on iPhone 8 landscape is 667 and max-widths are sitting in and around 600-640 in components/tokenTable/index.js

Maybe up all them to something sweet between iPhone landscape and iPad portrait, but good luck appeasing every device difference 👌💪🙏