vexe / VFW

MIT License
492 stars 67 forks source link

The type or namespace name `ItemPair`2' could not be found. #82

Closed pointcache closed 8 years ago

pointcache commented 8 years ago

Assets/Plugins/Vexe/Runtime/Libs/Helpers/ReflectionHelper.cs(55,30): error CS0246: The type or namespace name ItemPair2' could not be found. Are you missing a using directive or an assembly reference?

vexe commented 8 years ago

I renamed Tuple to ItemPair because it was causing issues in some platforms because they already have System.Tuple. Seems git didn't catch that rename or something. Downloading the Zip does yield the error. I'm on it.

pointcache commented 8 years ago

thanks for quick reply, could you also write down upgrade instructions? since you deprecated a whole lot on which my systems hold

vexe commented 8 years ago

It's more a downgrade at this stage. If your code relies on previous stuff, you could still use them (they're still there, not removed) - or you could stick to 1.3.4 in your current project (which is quite stable to be honest).

This is the thing about API design, you come up with an idea that you think is cool at the time of writing, you encourage people to use it, but then you find out you're totally wrong, and you were encouraging bad habits all along. But at that point it could be too late to undo the damage. I'd rather hit one down/up grade road bump rather than leaving users with code that I know is bad and will cause them tons of headaches in the future.

pointcache commented 8 years ago

So you actually removed BEtterBehavs with all the attributes? Like all of it or there is a substitution?

vexe commented 8 years ago

Just look at the "VFW Deprecated" folder, everything I deprecated is there. It's just BetterBehaviour and all the other serialization nonsense ([Serialize], [DontSerialize], etc), as well as delegates. The majority/rest of the drawers/attributes are all intact.

vexe commented 8 years ago

Could you try that again? https://github.com/vexe/VFW/commit/fec08aa859b08360d30970fe9d87faf8e0d6d6f3

pointcache commented 8 years ago

Done! Tested, works, thank you.

vexe commented 8 years ago

Awesome! Let me know if you have any more issues down the line.

Don't know if you noticed, but I just sneaked in another commit. You might have already got it but just in case, it was something I overlooked to rename.

pointcache commented 8 years ago

@vexe hey man could you give me 10 mins on skype i want to show you something, add me if you want antonov.3d

vexe commented 8 years ago

Could you perhaps write me in email or send me screenshots? or is it not possible?

pointcache commented 8 years ago

nah it would take too long, just wanted to share screen to show what i did with your framework thats all

vexe commented 8 years ago

OK Sure.