Closed Udera closed 8 years ago
@Udera I am (slowly) working on it.
@Udera After merging #4 the plugin is compatible (not complete, though).
@soujak Thanks for updating this plugin. There is probably a minor issue with the naming of the spam-drop field: axel_on_movespam
does not exist in vexim where this field is called spam_drop
.
@Udera Could you please confirm the two are exactly the same field? I haven't comprehensively compared their usage yet.
From what I remember, they are exactly the same. Before using this plugin, we must test this before.
OK. I am testing the translation it in this very moment.
By the way, when the corresponding "axel" option is disabled, such option is just unavailable in the web page, so the user is missing a configuration option. Otherwise it the "axel" option is enabled, the user can edit it, but such setting is just ignored by VExim. It should not generate any problem.
You could disable the "axel"-stuff completely. But we implemented the same functionality with spam_drop and it would be configurable. Normally it should work fine by just renaming everything to spam_drop. Just give it a try. If you are stuck at some point, you can upload your current state to github and we can have a look into it.
Yes, substituting and promoting possible conditionals worked immediately: #5 .
@soujak : Nice work, it really looks nice in roundcube.
I've seen two minor problems:
Move tagged spam to subfolder
doesn't fit the description. If spam_drop=0
spam-mails will be moved (box is not checked). If spam_drop=1
spam-mails will be deleted (box is checked).Block by header
part. There is nothing added to the database.Hm, would it be impolite to suggest to transfer this repository under Vexim organization?
@rimas-kudelis : That's a good suggestion! Can you grant me permissions to the vexim organization, so I can initiate the transfer?
Done. Thinking about the repo name now. I think it should contain the word "Roundcube", or at least "RC".
How about "Roundcube-Plugin-VeximAccountAdmin"? That's what several other plugins use as well.
sounds good
OK, I've renamed the repository, and edited the README while I'm at it. Thanks @corux! :)
@corux: interestingly, all stock plugins use snake_case for their names, ours just concats all words. Maybe it's worth renaming it?
First, the plugin should be added to https://plugins.roundcube.net/. Then the github repo name does not matter anymore. As plugin name on plugins.roundcube.net, I am definitely for the official naming convention (e.g. vexim/vexim_account_admin).
okay, good to know we agree on this. :) As you can see, I've made several pull requests. I hope you have time to review them. @Udera, if you could take a look after these are merged, that would be great. This bug is kinda fuzzy, so I'm not sure if they solve all problems, or not.
@rimas-kudelis, the pull requests look good. Great work! As I don't have a vexim installation anymore, I cannot test it though. Please merge them back to master yourself.
I see, ok, thanks!
Most seems to be fixed.
We are currently working on a new release of vexim 2.3. There won't be a new design but some important patches for the current configuration will be put into official code (remove clear passwords, more advanced password hashing, option to move or drop spam, ...): https://github.com/avleen/vexim2/issues/62
It would be nice to see a compatible version of this roundcube plugin ;-)