search

vexim / vexim2

Virtual Exim 2
Other
71 stars 47 forks source link

group feature, is_public should be boolean #256

Open runout-at opened 6 years ago

runout-at commented 6 years ago

The groups table has a field is_public which is of type string

Since all other Checkbox fields in vexim are boolean (integer in DB) i'd like to change this. Involved is one router.

Udera commented 6 years ago

postgresql does not seem to have the tinyint field type ....

https://stackoverflow.com/questions/1942586/comparison-of-database-column-types-in-mysql-postgresql-and-sqlite-cross-map

runout-at commented 6 years ago

my PR is using smallint for pgsql:

"is_public" smallint NOT NULL DEFAULT '1' CHECK("enabled" BETWEEN 0 AND 1),

rimas-kudelis commented 6 years ago

Since this is a cosmetic change only, but it involves the database, I would prefer to have this changed in 3.0, when we have proper migration support.