Bug in voted? - Githubissues

vext01 / hgd

Hackathon Gunther Daemon :: Opensource Multi-User Jukebox

http://hgd.theunixzoo.co.uk

ISC License

22 stars 10 forks source link

Bug in voted? #119

Closed jonentropy closed 13 years ago

jonentropy commented 13 years ago

voted? can be returned as true when the playlist empties and another track is queued, if the user voted off the one and only song playing. It fixes itself after another call to ls.

egelmex commented 13 years ago

Can you paste a log of messages sent? I don't really understand what your describing.

jonentropy commented 13 years ago

I have no log at the moment but steps to reproduce are:

Run netd and playd.
Queue one song
Vote it off
Run ls. voted? will be "1"
Let song finish, or skip it.
Queue another song.
Run ls. voted? will be "1". ==[BUG]
Run ls. voted? will be "0".

egelmex commented 13 years ago

Ah this is referencing your pullrequest?

On Mon, Oct 10, 2011 at 1:53 PM, Tristan Linnell reply@reply.github.com wrote:

I have no log at the moment but steps to reproduce are:

Run netd and playd.

Queue one song

Vote it off

Run ls. voted? will be "1"

Let song finish, or skip it.

Queue another song.

Run ls. voted? will be "1". ==[BUG]

Run ls. voted? will be "0".

Reply to this email directly or view it on GitHub: https://github.com/vext01/hgd/issues/119#issuecomment-2347039

jonentropy commented 13 years ago

Yes. Sorry. The bug exists now though.

vext01 commented 13 years ago

fixed