Add -Wall to CFLAGS and fix all warnings

[vext01]

We lost -Wall in the new build system.

[reashlin]

Sorry guys and gals. Nothing but warnings though I know it's important.

Currently running Fedora 13 (excuse the age I'm a slacker) I can provide more version details if necessary.

$ make 2>errors; cat errors | xsel -i

and you've got the following

py.c: In function ‘hgd_py_meth_dealloc’: py.c:257: warning: suggest explicit braces to avoid ambiguous ‘else’ py.c:259: warning: suggest explicit braces to avoid ambiguous ‘else’ hgd-mk-pydoc.c: In function ‘hgd_mk_pydoc’: hgd-mk-pydoc.c:91: warning: suggest explicit braces to avoid ambiguous ‘else’ hgd-mk-pydoc.c:93: warning: suggest explicit braces to avoid ambiguous ‘else’ hgd-mk-pydoc.c:95: warning: suggest explicit braces to avoid ambiguous ‘else’ hgd-mk-pydoc.c:56: warning: unused variable ‘args’

[reashlin]

Just had confirmation from edd this is a new one on him (tm)

as such see the following

$ gcc -v Using built-in specs. Target: x86_64-redhat-linux Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk --disable-dssi --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre --enable-libgcj-multifile --enable-java-maintainer-mode --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --disable-libjava-multilib --with-ppl --with-cloog --with-tune=generic --with-arch_32=i686 --build=x86_64-redhat-linux Thread model: posix gcc version 4.4.5 20101112 (Red Hat 4.4.5-2) (GCC)

[vext01]

can you try now