Adding support to heartbeat monitor type

vexxhost / terraform-provider-uptimerobot

A terraform provider for UptimeRobot

Mozilla Public License 2.0

30 stars 16 forks source link

Adding support to heartbeat monitor type #15

Closed rogerioefonseca closed 2 years ago

rogerioefonseca commented 2 years ago

[x] Added support to heartbeat
[x] Created test to evaluate it's usage
[x] Tested locally
[x] Need to test the others Heartbeat parameters
[x] Refactor to reduce the number of lines
[x] Adding usage into README website file

Closes: #16

mnaser commented 2 years ago

@rogerioefonseca do you think you'll have some spare time to go over this and finish it up at some point? :)

rogerioefonseca commented 2 years ago

@rogerioefonseca do you think you'll have some spare time to go over this and finish it up at some point? :)

Hello there, actually I did already, I just need to push to this repo as well. Tomorrow I'll do it.

mnaser commented 2 years ago

@rogerioefonseca do you think you'll have some spare time to go over this and finish it up at some point? :)

Hello there, actually I did already, I just need to push to this repo as well. Tomorrow I'll do it.

Awesome, thank you.

rogerioefonseca commented 2 years ago

Hmmm, not sure how can I fix those conflicts... I'm not sure what am I doing wrong, But I cannot see those locally and in github as well..

rogerioefonseca commented 2 years ago

Hmmm, not sure how can I fix those conflicts... I'm not sure what am I doing wrong, But I cannot see those locally and in github as well..

@mnaser can you help me with that?

mnaser commented 2 years ago

If you click on this, it will provide you the instructions on how to do that :)