vezel-dev / cathode

A terminal-centric replacement for the .NET console APIs.
https://docs.vezel.dev/cathode
BSD Zero Clause License
91 stars 7 forks source link

`ChildProcessReader` can bubble up internal exceptions to `ChildProcess.Completion` #138

Closed alexrp closed 6 months ago

alexrp commented 6 months ago

https://github.com/vezel-dev/cathode/blob/69f1c657165bede3829d02b50b95e95894dcdf76/src/core/Processes/ChildProcessReader.cs#L32-L48

Under exceptional circumstances, some exception types can slip through here and bubble up to the ChildProcess.Completion task. We should figure out what these exception types are and what the appropriate way to deal with them is (I suspect just turn them into a ChildProcessException).