search

vezinaca / Banq_Achat

Divers scripts qui interagissent avec la BANQ
0 stars 0 forks source link

I know you'll hate me for this #4

Closed gregsadetsky closed 4 years ago

gregsadetsky commented 4 years ago

it'd be good to use clearer, non jokey variable names :-)

bs4's examples simply use "soup" as the variable name, which is really not great, but kinda better.

I mean, it's a very small thing but I'm prepping you for an interview :-) so yeah. x

https://github.com/vezinaca/Banq_Achat/blob/11f3a9cbee370c9c3c03fa3372e57164e619ddc3/scrape_catalogue.py#L47

vezinaca commented 4 years ago

I chose 'soup' for now.

gregsadetsky commented 4 years ago

great, closing this (feel free to close next time when you've made a change (((you can also reference issue in your git commits, so you could have said "improving variable names to fix #4", and the git commit and this issue would have been linked))) xx