search

vfarcic / crossplane-tutorial

43 stars 276 forks source link

Argocd helm chart setting global.domain needs overriding #15

Closed andrewhibbert closed 4 months ago

andrewhibbert commented 4 months ago

https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/values.yaml#L42

global.domain is set to argocd.example.com, this needs overriding to argocd.127.0.0.1.nip.io for the ingress to work

vfarcic commented 4 months ago

Right now the host is set in server.ingress.hosts[0] (https://github.com/vfarcic/crossplane-tutorial/blob/main/argocd/helm-values.yaml#L14). Should it be in global.domain as well?

andrewhibbert commented 4 months ago

Yes, might also be worth installing specific versions

vfarcic commented 4 months ago

Would you like to make a PR?