vfarcic / crossplane-tutorial

42 stars 276 forks source link

Gist Part 3 + Video continuity issue #19

Closed jason-bent closed 3 months ago

jason-bent commented 3 months ago

@vfarcic

Found small continuity issue within Gist Part 3 related video

I believe we should use sql-v2 rather than sql-v1 with the change from matchLabels to use matchControllerRef confirmation, otherwise we are just applying the same composition as before...

#####################################
# Resource References and Selectors #
#####################################

cat examples/$HYPERSCALER-vm.yaml

cat compositions/sql-v1/$HYPERSCALER.yaml

cat compositions/sql-v2/$HYPERSCALER.yaml

# kubectl apply --filename compositions/sql-v1 # <-- Should be sql-v2
kubectl apply --filename compositions/sql-v2

kubectl delete --filename examples/$HYPERSCALER-sql-v1.yaml # <-- This is correct

kubectl get managed
vfarcic commented 3 months ago

You're right. That was a huge mistake on my part. I got sidetracked that there should be no difference in the outcome that I applied the old version. It's corrected now. Thanks a ton for letting me know.

jason-bent commented 3 months ago

@vfarcic

Correction.

#####################################
# Resource References and Selectors #
#####################################

cat examples/$HYPERSCALER-vm.yaml

cat compositions/sql-v1/$HYPERSCALER.yaml

cat compositions/sql-v2/$HYPERSCALER.yaml

# kubectl apply --filename compositions/sql-v1 # <-- Should be sql-v2
kubectl apply --filename compositions/sql-v2

kubectl delete --filename examples/$HYPERSCALER-sql-v1.yaml # <-- This is correct

kubectl get managed
vfarcic commented 3 months ago

Oh my... I was too hasty with the changes. Now it should be fine. Thanks a ton.